Skip to content

update minum delay to be compatible with Quantum Machines#1385

Merged
alecandido merged 1 commit into
mainfrom
tof_min_delay
Jul 8, 2026
Merged

update minum delay to be compatible with Quantum Machines#1385
alecandido merged 1 commit into
mainfrom
tof_min_delay

Conversation

@jevillegasd

Copy link
Copy Markdown
Contributor

A tof routine while using OPX1000 returns

Invalidation ERROR time of flight@elements.0/acquisition: Time of flight must be a multiple of 4 and greater or equal than 28 (got 24)

This can be changed in the MINIMUM_TOF constant (this PR), or perhaps be part of the instrument bounds (part of the driver or in the configs json)

@codecov

codecov Bot commented Feb 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.81%. Comparing base (bff85ba) to head (4c4e6ae).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         147      147           
  Lines       11643    11643           
=======================================
  Hits        10690    10690           
  Misses        953      953           
Flag Coverage Δ
unittests 91.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ocols/signal_experiments/time_of_flight_readout.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alecandido alecandido left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late reply. I was postponing because of the failing tests, but they are actually failing at random... The change is minimal, and certainly fine.

@alecandido

Copy link
Copy Markdown
Member

Btw, I agree it should be eventually moved to the drivers. It does not make sense to limit all the instruments to the one with the strongest requirement.
However, this is not high enough in priority to motivate the introduction of a dedicated configuration section for instruments, standardized across the various drivers. Also because we have to account for multiple instruments possibly involved, and in this case there is even a non-trivial interaction about the channel assignment (so, you should navigate to the instrument owning the channel, and find its limitation about the time of flight in the standard section).

In any case, we already have a close enough issue, and we can revisit this when we will look deeper into that qiboteam/qibolab#854

@alecandido alecandido requested review from a team and scarrazza July 8, 2026 06:19
@alecandido alecandido added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 9b3c354 Jul 8, 2026
39 checks passed
@alecandido alecandido deleted the tof_min_delay branch July 8, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants